Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): get edited licenses list for an upload #2498

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

dushimsam
Copy link
Contributor

@dushimsam dushimsam commented Jun 26, 2023

Description

Added the API to retrieve a list of the edited licenses for a given upload.

Changes

  1. Added a new method in UploadController to handle the logic.
  2. Updated the main file(index.php) by adding a new route GET /uploads/{id}/licenses/edited.
  3. Updated the openapi.yaml file to introduce a new API.

How to test

Make a GET request on the endpoint: /uploads/{id}/licenses/edited.

Screenshots

UI View:

image

API response:

image

Related Issue:

Fixes #2467

cc: @shaheemazmalmmd @GMishx

@dushimsam dushimsam changed the title feat(api): get edited licenses list feat(api): get edited licenses list for an upload Jun 26, 2023
@GMishx GMishx added needs code review needs test GSOC-23 Label to tag pull request which are part of the GSOC 2023 labels Jun 28, 2023
@github-actions github-actions bot added the has merge conflicts PR to be rebased label Jun 29, 2023
@github-actions
Copy link

This pull request has conflicts, please rebase with master to resolve those before we can evaluate the pull request.

src/www/ui/api/documentation/openapi.yaml Outdated Show resolved Hide resolved
@GMishx
Copy link
Member

GMishx commented Jul 10, 2023

Tested, working as expected.

@github-actions
Copy link

This pull request has conflicts, please rebase with master to resolve those before we can evaluate the pull request.

Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good.

Signed-off-by: dushimsam <dushsam@gmail.com>
@github-actions github-actions bot removed the has merge conflicts PR to be rebased label Jul 24, 2023
@GMishx GMishx merged commit 3d6195a into fossology:master Jul 26, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GSOC-23 Label to tag pull request which are part of the GSOC 2023 ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

License Browser - Scanner Licenses
2 participants