-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): Update Upload Summary API to add more info #2499
Conversation
e5bd92a
to
daf87eb
Compare
This pull request has conflicts, please rebase with master to resolve those before we can evaluate the pull request. |
Would recommend extending existing endpoint
|
Yes, that looks better. |
But again @GMishx, The new API only returns the summary of upload for the licenses section, not for other modules like copyrights. The values returned by the new API also vary depending on the agentId selected. Given these factors, do you think it is appropriate to include them in the existing implementation? Let me know what you think and then I will go with your suggestion. Thank you. |
Oh, I didn't notice the endpoint is dependent on agent id. But still, they can be merged if the agent id is not provided, the current behavior can be followed. Otherwise, the values will change based on agent id. It is better to send little more information from a single endpoint than creating one more which shares the same info. Creating new endpoint will also cause confusion if more than 1 endpoint can be used to get same info (and will also need multiple calls if info from both endpoint is needed :-)) |
daf87eb
to
481c206
Compare
Awesome, I have applied the new changes to the current implementation and have revised the commit and the PR's description. Thank you very much. |
Signed-off-by: dushimsam <dushsam@gmail.com>
481c206
to
ac18976
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good.
Tested, working as expected.
Description
Update the current API to for getting the upload's summary to add more information related to licenses.
Changes
getUploadSummary
inUploadController
to make the changes.openapi.yaml
file to introduce a new changes for the API.How to test
Make a GET request on the endpoint:
/uploads/{id}/summary
.Screenshots
Related Issue:
Fixes #2467
cc: @shaheemazmalmmd @GMishx