Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): Get all licenses-admin acknowlegments #2512

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

dushimsam
Copy link
Contributor

@dushimsam dushimsam commented Jul 3, 2023

Description

Added the API to retrieve a list of the licenses' admin acknowledgments.

Changes

  1. Added a new method in LicenseController to build the functionality.
  2. Updated the main file(index.php) by adding a new route GET /licenses/adminacknowlegments.
  3. Updated the openapi.yaml file to write the new API's documentation.

How to test

Make a GET request on the endpoint: /licenses/adminacknowlegments,

Screenshots

image

Related Issue:

Fixes #2511

cc: @shaheemazmalmmd @GMishx

@dushimsam dushimsam force-pushed the get-all-adminacknowlegements branch 3 times, most recently from 4a78283 to 015afb1 Compare July 3, 2023 17:26
@GMishx GMishx added needs code review needs test GSOC-23 Label to tag pull request which are part of the GSOC 2023 labels Jul 5, 2023
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change.

src/www/ui/api/documentation/openapi.yaml Outdated Show resolved Hide resolved
@GMishx
Copy link
Member

GMishx commented Jul 24, 2023

Tested, working as expected.

@GMishx GMishx removed the needs test label Jul 24, 2023
@dushimsam dushimsam force-pushed the get-all-adminacknowlegements branch from 015afb1 to c971a74 Compare July 24, 2023 15:37
Signed-off-by: dushimsam <dushsam@gmail.com>
@dushimsam dushimsam force-pushed the get-all-adminacknowlegements branch from c971a74 to bf5a8c5 Compare July 24, 2023 15:38
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good.

@GMishx GMishx merged commit 4bc611a into fossology:master Jul 26, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GSOC-23 Label to tag pull request which are part of the GSOC 2023 ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

License Admin
2 participants