-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix(php) : Fix null pointer issue in createClearingDecisions() #2658
Conversation
Signed-off-by: Kgitman <95560077+Kgitman@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the commit message according to our contributing guidelines.
Ok, |
Yes, code changes are good. Please change just the commit message. |
Done? |
I see no difference @Kgitman |
Sorry for that i changed the description , I edited the commit message please review. |
Oh, I see. But I meant the actual commit message, not the PR title or description. Since it is the once which will end up in the commit history. |
Signed-off-by: Kgitman <95560077+Kgitman@users.noreply.github.com>
Is this ok? Please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Not exactly, was expecting to have only 1 commit at the end (using |
…logy#2658) fix(php) : Fix null pointer issue in createClearingDecisions() Signed-off-by: Kgitman <95560077+Kgitman@users.noreply.github.com> Reviewed-by: mishra.gaurav@siemens.com
Description
This pull request addresses a potential null pointer issue #2656 in the
createClearingDecisions()
method withinDecisionImporterDataCreator.php
Closes #2656.
Changes
$newCeId
before processing within the foreach loop.if ($newCeId === null) { continue; }
to ensure the loop skips operations if$newCeId
is null.How to test
$newCeId
could be null./cc @GMishx