Item13950: Don't abort rest for cache refresh requests

Kinder & Gentler - just demote a global refresh=all to refresh=cache for rest requests, since they don't handle errors as easily.
foswiki · Feb 13, 2016 · 780d3d1 · MichaelDaum · Feb 15, 2016 · 780d3d1
1 parent e7ec532
commit 780d3d1
Showing 1 changed file with 16 additions and 6 deletions.
diff --git a/core/lib/Foswiki/PageCache.pm b/core/lib/Foswiki/PageCache.pm
@@ -318,12 +318,22 @@ sub getPage {
             $this->deleteAll();
         }
         else {
-            throw Foswiki::OopsException(
-                'accessdenied',
-                def   => 'cache_refresh',
-                web   => $web,
-                topic => $topic,
-            );
+            my $session = $Foswiki::Plugins::SESSION;
+            my $request = $session->{request};
+            my $action  = substr( ( $request->{action} || 'view' ), 0, 4 );
+            if ( $action eq 'rest' ) {
+
+                # Demote 'all' to 'cache' rather than kill rest
+                $refresh = 'cache';
+            }
+            else {
+                throw Foswiki::OopsException(
+                    'accessdenied',
+                    def   => 'cache_refresh',
+                    web   => $web,
+                    topic => $topic,
+                );
+            }
         }
     }