Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add validation dataset to train #6

Closed
Ssukriti opened this issue Dec 26, 2023 · 1 comment · Fixed by #26
Closed

add validation dataset to train #6

Ssukriti opened this issue Dec 26, 2023 · 1 comment · Fixed by #26
Assignees
@anhuong
Labels
good first issue Good for newcomers

Comments

@Ssukriti
Copy link
Collaborator

Description

currently the train only accepts JSON file to a train dataset. We also need to add support for validation dataset to enable early stopping and possibly other features in the future

Acceptance Criteria

  1. Accept validation dataset in train
@Ssukriti Ssukriti added the good first issue Good for newcomers label Dec 26, 2023
@chakrn
Copy link

chakrn commented Jan 3, 2024

Corresponding issue in internal repo: https://github.ibm.com/ai-foundation/watson-fm-stack-tracker/issues/554

@anhuong anhuong mentioned this issue Jan 30, 2024
Merged
@anhuong anhuong self-assigned this Jan 30, 2024
kpouget pushed a commit to kpouget/fms-hf-tuning that referenced this issue Jun 19, 2024
@moulalis
Merge pull request foundation-model-stack#6 from red-hat-data-service…
1abf4e9 
…s/appstudio-fms-hf-tuning-release

Red Hat Konflux update fms-hf-tuning-release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anhuong anhuong

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add validation dataset to train foundation-model-stack/fms-hf-tuning
3 participants
@Ssukriti @anhuong @chakrn