Fix smoothScroll reference in foundation.js #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kball, could you please take a look? |
ncoden
approved these changes
Mar 11, 2018
There was a problem hiding this comment.
👍 LGTM for now, but I think that we should provide the compiled foundation.js directly instead of this concatenation of plugins. Thanks @MicahBrown.
ncoden
added a commit
to ncoden/foundation-rails
that referenced
this pull request
Mar 13, 2018
### Major changes: * Upgrade to Foundation `v6.4.3` (foundation#254, @chrisfinne) * Add Autoprefixer (foundation#255, @bassjobsen) ### Bug fixes: * Fix issue with smoothScroll import order (foundation#236 @MicahBrown) * Add missing SCSS components to template (foundation#237 @patricklindsay) * Prevent Sass depreciation (foundation#252, @michsch) ### Cleaning: * Remove old Foundation files (foundation#251 @jessedoyle) ### See also: * Foundation 6.4.3 release notes: https://github.com/zurb/foundation-sites/releases/tag/v6.4.3 * Foundation 6.4.2 release notes: https://github.com/zurb/foundation-sites/releases/tag/v6.4.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for the issue I posted in #235. Magellan seems to reference smoothScroll, which causes issues in development on rails
5.1.2, since it's being included after magellan.js in the foundation.js manifest.