Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLEANUP] Remove Sass deprecation warning #252

Merged
merged 1 commit into from
Mar 11, 2018
Merged

[CLEANUP] Remove Sass deprecation warning #252

merged 1 commit into from
Mar 11, 2018

Conversation

michsch
Copy link
Contributor

@michsch michsch commented Dec 19, 2017

DEPRECATION WARNING: #{} interpolation near operators will be simplified in a future version
of Sass.

Source:
https://github.com/zurb/foundation-sites/blob/eaa79c89a8c5dc89f8fa1e6916ce5dea6cc55866/scss/xy-grid/_gutters.scss#L33

This closes #246

DEPRECATION WARNING: #{} interpolation near operators will be simplified in a future version
of Sass.

Source:
https://github.com/zurb/foundation-sites/blob/eaa79c89a8c5dc89f8fa1e6916ce5dea6cc55866/scss/xy-grid/_gutters.scss#L33

This closes #246
Copy link
Contributor

@ncoden ncoden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM, thank you @michsch

@ncoden ncoden merged commit 6cfa530 into foundation:master Mar 11, 2018
@oliverklee oliverklee deleted the cleanup/remove-sass-deprecation-warning branch March 11, 2018 22:53
ncoden added a commit to ncoden/foundation-rails that referenced this pull request Mar 13, 2018
### Major changes:
* Upgrade to Foundation `v6.4.3` (foundation#254, @chrisfinne)
* Add Autoprefixer (foundation#255, @bassjobsen)

### Bug fixes:
* Fix issue with smoothScroll import order (foundation#236 @MicahBrown)
* Add missing SCSS components to template (foundation#237 @patricklindsay)
* Prevent Sass depreciation (foundation#252, @michsch)

### Cleaning:
* Remove old Foundation files (foundation#251 @jessedoyle)

### See also:
* Foundation 6.4.3 release notes:
  https://github.com/zurb/foundation-sites/releases/tag/v6.4.3
* Foundation 6.4.2 release notes:
  https://github.com/zurb/foundation-sites/releases/tag/v6.4.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants