Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: Move typescale from prototype to typography and enable default! #10351

Merged
merged 3 commits into from Jul 5, 2017

Conversation

IamManchanda
Copy link
Contributor

Another try to fix #10301

Reason:

  • We found out that extend is failing in ruby sass ... it sucks btw on my part that i didnt knew this will fail in ruby sass
  • This is not adding any extra css ... Basically its just h1, .h1 instead of h1 so no such bloat that could harm the code if enable by default!

@kball kball merged commit 75a9fec into develop Jul 5, 2017
@IamManchanda
Copy link
Contributor Author

Another thing to add in for records

Considering Accessibility,
This is a very Good helper class!

kball added a commit that referenced this pull request Jul 25, 2017
Hotfix: Move typescale from prototype to typography and enable default!
@colin-marshall colin-marshall deleted the hotfix/add-typescale branch January 19, 2018 17:58
@januszm
Copy link

januszm commented Mar 10, 2018

Could you please release this also as a Ruby gem? It's not possible to use @include foundation-prototype-classes; with Ruby on Rails + foundation-rails gem because of this issue.

@ncoden
Copy link
Contributor

ncoden commented Mar 10, 2018

Related to foundation/foundation-rails#254. I'll take a look at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Base-level rules cannot contain the parent-selector-referencing character '&'.
4 participants