-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Base-level rules cannot contain the parent-selector-referencing character '&'. #10301
Comments
Possible duplicate: Issue 10279 |
Yup duplicate but different code and this need to fix too |
@IamManchanda can you find where in |
I just tested with ruby sass against develop and am not seeing errors in the main compile (including button group, as well as menu/xy where we were seeing some ruby sass problems before). I am seeing an error with rubysass if I include the prototype classes:
@IamManchanda do you have time to look into that? If not I'll get it after some teaching but before I package up 6.4.1 today |
Hey guys, more info on my bug.
For some testing I removed button group and then the error moved to the
following included component.
So for some reason it's just showing me the error starting at button group.
But I can't be sure that's where it's originating.
It's real weird.
…On Fri, Jun 30, 2017 at 10:54 AM Kevin Ball ***@***.***> wrote:
I just tested with ruby sass against develop and am not seeing errors in
the main compile (including button group, as well as menu/xy where we were
seeing some ruby sass problems before).
I am seeing an error with rubysass if I include the prototype classes:
Error: You may not @extend an outer selector from within @media.
You may only @extend selectors within the same directive.
From ***@***.*** h1" on line 15 of scss/prototype/_typescale.scss.
on line 105 of _vendor/normalize-scss/sass/normalize/_normalize-mixin.scss
@IamManchanda <https://github.com/iammanchanda> do you have time to look
into that? If not I'll get it after some teaching but before I package up
6.4.1 today
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#10301 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACX_sRVpmqQ42mfpmINzDeO5XTTArDDcks5sJSgagaJpZM4OKGfW>
.
|
Oh Jesus, Seems like the problem is here http://foundation.zurb.com/sites/docs/prototyping-utilities.html#typescale |
@devanflaherty I've just published 6.4.1, which resolved the known issues associated with this outside of the opt-in prototyping helpers, so for a base install should "just work". Can you try it out and verify this is resolved for you? |
Working great!
…On Fri, Jun 30, 2017 at 4:39 PM Kevin Ball ***@***.***> wrote:
@devanflaherty <https://github.com/devanflaherty> I've just published
6.4.1, which resolved the known issues associated with this outside of the
opt-in prototyping helpers, so for a base install should "just work". Can
you try it out and verify this is resolved for you?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#10301 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACX_sR9z9mSrmGWXL1KEg7hQ7yLjfJ6hks5sJXkKgaJpZM4OKGfW>
.
|
@IamManchanda any thoughts on resolving this prototyping scss issue? |
@kball Can we just move typescale from prototyping helpers to typography part but still keep it disabled by default?? |
We can move it, but does that resolve the @extend/@media issue? |
Yes if we move it here... this will most probably resolve the issue |
@IamManchanda lets try it - move it over and then test with ruby sass once you have (or if you prefer I can test it) |
Yeah doing it now ... you test it as i dont use/know ruby(Me and my love of Php) ... so you test it ... doing a PR shortly 😉 |
Still keeping it disabled by default Fix #10301
Just upgraded my rails project to use Foundation 6.4.
It was a new project I hadn't modified any code so replacing the settings.scss was easy and I was previously only selecting what components I wanted to load in.
I thought it would be seamless but I'm getting this :
Base-level rules cannot contain the parent-selector-referencing character '&'.
It's showing me this error for
@include foundation-button-group;
I have foundation-sites installed via yarn, but I'm compiling the scss through rails asset pipeline.
Any help please, I'm dead in the water here.
The text was updated successfully, but these errors were encountered: