Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add SonarCloud config file #11809

Merged
merged 1 commit into from Feb 3, 2020
Merged

ci: add SonarCloud config file #11809

merged 1 commit into from Feb 3, 2020

Conversation

DanielRuf
Copy link
Contributor

@DanielRuf DanielRuf commented Aug 25, 2019 •
edited

Description

This PR adds the config file for SonarCloud so we can add / enable it there to check the code for code smells and other issues.

Types of changes

  • Documentation
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (anything that would change an existing functionality)
  • Maintenance (refactor, code cleaning, development tools...)

Checklist

  • I have read and follow the CONTRIBUTING.md document.
  • The pull request title and template are correctly filled.
  • The pull request targets the right branch (develop or develop-v...).
  • My commits are correctly titled and contain all relevant information.
  • I have updated the documentation accordingly to my changes (if relevant).
  • I have added tests to cover my changes (if relevant).

@SassNinja
Copy link
Contributor

@DanielRuf who's gonna create the necessary account and when is the analysis supposed to be triggered?

@SassNinja
Copy link
Contributor

doesn't make much sense to merge this PR until the config contains some content

@DanielRuf
Copy link
Contributor Author

doesn't make much sense to merge this PR until the config contains some content

The config can be empty by default which sets the default values.

@DanielRuf
Copy link
Contributor Author

@DanielRuf who's gonna create the necessary account and when is the analysis supposed to be triggered?

Someone with the proper rights (owner, admin) to add the application from the marketplace.

@weekly-digest weekly-digest bot mentioned this pull request Sep 9, 2019
Closed
@weekly-digest weekly-digest bot mentioned this pull request Oct 13, 2019
Closed
@DanielRuf DanielRuf requested review from a team and removed request for kball, colin-marshall, rafibomb, JeremyEnglert and SassNinja January 13, 2020 22:49
@weekly-digest weekly-digest bot mentioned this pull request Jan 19, 2020
Closed
@joeworkman
Copy link
Member

I started work on getting this configured.

@joeworkman joeworkman merged commit 06b5802 into foundation:develop Feb 3, 2020
@weekly-digest weekly-digest bot mentioned this pull request Feb 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeworkman joeworkman joeworkman approved these changes

Assignees

@joeworkman joeworkman

Labels
🚚 build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DanielRuf @SassNinja @joeworkman