Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #12080, !global variable declarations generating warnings with SASSC. #12195

Merged
merged 8 commits into from
Aug 24, 2021

Conversation

ycrepeau
Copy link
Contributor

@ycrepeau ycrepeau commented Jan 23, 2021

Description

The last version of sassc issues a warning each time a !global variable is set, except if such a setting is done at the root level.

The current pull-request add a patches to 3 files by déclaring the variables at root level.

Types of changes

  • Documentation
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (anything that would change an existing functionality)
  • Maintenance (refactor, code cleaning, development tools...)

Checklist

  • I have read and follow the CONTRIBUTING.md document.
  • The pull request title and template are correctly filled.
  • The pull request targets the right branch (develop or develop-v...).
  • My commits are correctly titled and contain all relevant information.
  • I have updated the documentation accordingly to my changes (if relevant).
  • I have added tests to cover my changes (if relevant).

package.json Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jan 24, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented May 31, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kagarmoe
Copy link

Hi - I'd love to get this patch sometime soon! Thanks.

@ycrepeau
Copy link
Contributor Author

Hi - I'd love to get this patch sometime soon! Thanks.

So do I. The patch has been ready since January 24th. 2021.

Maybe I have missed some details on the approval process and I don't know what I have to do to have is issue finally resolved.

@joeworkman joeworkman merged commit 7980aac into foundation:develop Aug 24, 2021
@javierm javierm mentioned this pull request Apr 17, 2022
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sass !global variable declaration deprecation warning
4 participants