Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #12080, !global variable declarations generating warnings with SASSC. #12195

Merged
merged 8 commits into from
Aug 24, 2021
Merged

Fix issue #12080, !global variable declarations generating warnings with SASSC. #12195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1d4b4ad
Fixing the !global warning
ycrepeau Jan 23, 2021
7a1e82c
Fix issue 12080
ycrepeau Jan 23, 2021
88bc812
fix: once all test passed ok locally
ycrepeau Jan 23, 2021
58bab86
fix: install mocha
ycrepeau Jan 23, 2021
af511b9
fix: remove local mocha
ycrepeau Jan 23, 2021
9d37294
fix: bring back local mocha
ycrepeau Jan 23, 2021
5969534
fix: restored (rolledback) package.json and yarn.lock
ycrepeau Jan 24, 2021
b3c62f8
Merge branch 'foundation:develop' into develop
ycrepeau May 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions scss/util/_breakpoint.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,12 @@
/// @group breakpoints
////

////
/// Patch to fix issue #12080

$-zf-size: null;
////

/// A list of named breakpoints. You can use these with the `breakpoint()` mixin to quickly create media queries.
/// @type Map
$breakpoints: (
Expand Down
10 changes: 10 additions & 0 deletions scss/util/_color.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,16 @@

$contrast-warnings: true !default;

////
/// Patch to fix issue #12080

$primary-color: null;
$secondary-color: null;
$warning-color: null;
$alert-color: null;
$success-color:null;
////

////
/// @group functions
////
Expand Down
5 changes: 5 additions & 0 deletions scss/util/_mixins.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@
/// @group functions
////

////
/// Patch to fix issue #12080
$-zf-pb-value: null;

////
/// Creates an inner box-shadow for only one side
///
/// @param {Keyword} $side - Side the shadow is supposed to appear. Can be `top`, `left`, `right` or `bottom`.
Expand Down