Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use "push.tags" webhook event #371

Closed
wants to merge 1 commit into from

Conversation

PaulRBerg
Copy link
Contributor

Makes the workflow added in #366 more robust by using the push webhook event instead of release, which doesn't work with releases made by other GitHub Actions workflows.

For more information, see anton-yurchenko/git-release#100.

@mds1
Copy link
Collaborator

mds1 commented May 5, 2023

Is the push event fired when the release+tag is created from the GitHub UI? In that case I never pushed from my machine to the origin, so I don't know if this will trigger. From the docs it's not clear to me

@PaulRBerg
Copy link
Contributor Author

No, it is not fired when you create a GitHub release via the GitHub UI.

https://docs.github.com/en/webhooks-and-events/webhooks/webhook-events-and-payloads#push

In this case, I think it would be best to keep it as is, but FYI the workflow will stop working once Forge Std moves to an automated way of generating the releases themselves.

@PaulRBerg PaulRBerg closed this May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants