Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

forge: add script/ to project paths #1877

Merged
merged 4 commits into from Jun 8, 2022
Merged

forge: add script/ to project paths #1877

merged 4 commits into from Jun 8, 2022

Conversation

joshieDo
Copy link
Collaborator

@joshieDo joshieDo commented Jun 8, 2022 •
edited

Motivation

Pending / Ref: gakonst/ethers-rs#1359

Currently, our convention on foundry is to have scripts in the script/ folder. 
However, the folder does not actually belong to the project. It may lead to weird issues, 
if there's contracts declared inside when verifying contracts.

Alternatively, we could also add a more generic additional_sources where by default we add the script/ folder.

Solution

mattsse
mattsse reviewed Jun 8, 2022
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed, that makes imo

@joshieDo joshieDo marked this pull request as ready for review June 8, 2022 13:04
mattsse
mattsse approved these changes Jun 8, 2022
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

cli/src/cmd/forge/build.rs
@@ -296,7 +296,7 @@ impl BuildArgs {
// use the path arguments or if none where provided the `src` dir
self.watch.watchexec_config(|| {
let config = Config::from(self);
vec![config.src, config.test]
vec![config.src, config.test, config.script]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

@mattsse mattsse merged commit e6efd2d into foundry-rs:master Jun 8, 2022
@mattsse mattsse mentioned this pull request Jun 9, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joshieDo @mattsse