feat(solc): add script/ to project paths #1359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshieDo
commented
Jun 8, 2022
| @@ -420,7 +437,8 @@ impl Default for ProjectPaths { | |||
| Self { | |||
| artifacts: "out".into(), | |||
| sources: "src".into(), | |||
| tests: "tests".into(), | |||
| tests: "test".into(), | |||
There was a problem hiding this comment.
I changed here, because it seems like tests was a mistake here. Should I revert it?
There was a problem hiding this comment.
that makes sense, is also the default of foundry::Config
joshieDo
commented
Jun 8, 2022
| @@ -538,7 +562,8 @@ impl ProjectPathsConfigBuilder { | |||
| .artifacts | |||
| .unwrap_or_else(|| ProjectPathsConfig::find_artifacts_dir(&root)), | |||
| sources: self.sources.unwrap_or_else(|| ProjectPathsConfig::find_source_dir(&root)), | |||
| tests: self.tests.unwrap_or_else(|| root.join("tests")), | |||
| tests: self.tests.unwrap_or_else(|| root.join("test")), | |||
There was a problem hiding this comment.
I changed here, because it seems like tests was a mistake here. Should I revert it?
mattsse
approved these changes
Jun 8, 2022
| @@ -420,7 +437,8 @@ impl Default for ProjectPaths { | |||
| Self { | |||
| artifacts: "out".into(), | |||
| sources: "src".into(), | |||
| tests: "tests".into(), | |||
| tests: "test".into(), | |||
There was a problem hiding this comment.
that makes sense, is also the default of foundry::Config
mattsse
approved these changes
Jun 8, 2022
we know we can decode them properly by this point, they are flaky because people change their info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, our convention on foundry is to have scripts in the
script/folder. However, the folder does not actually belong to the project. It may lead to weird issues, if there's contracts declared inside when verifying contracts.Alternatively, we could also add a more generic
additional_sourceswhere by default we add thescript/folder.Solution
PR Checklist