feat: add more fs cheatcodes #4803
Conversation
There was a problem hiding this comment.
File.t.sol -> Fs.t.sol
testdata/cheats/Fs.t.sol
Outdated
| // string memory path = "../testdata/fixtures/Dir"; | ||
|
|
||
| // { | ||
| // Cheats.DirEntry[] memory entries = cheats.readDir(path); |
There was a problem hiding this comment.
Just a single call fails with "allocation overflow", any ideas why?
There was a problem hiding this comment.
remembered this issue:
same error but turned out to be abi decoding related
but perhaps configured memory limit?
There was a problem hiding this comment.
Thanks, it was an ABI encoding error: 66723e4
Really weird that it throws a "memory overflow" tho
There was a problem hiding this comment.
yeh, perhaps our mapping of the internal solidity error is not entirely accurate
| createDir(string, bool) | ||
| removeDir(string, bool) | ||
| readDir(string)(DirEntry[]) | ||
| readDir(string, uint64)(DirEntry[]) | ||
| readDir(string, uint64, bool)(DirEntry[]) | ||
| readLink(string)(string) |
| /// Creates a new, empty directory at the provided path. | ||
| /// | ||
| /// If `recursive` is true, it will also create all the parent directories if they don't exist. | ||
| /// | ||
| /// # Errors | ||
| /// | ||
| /// This function will return an error in the following situations, but is not limited to just these | ||
| /// cases: | ||
| /// | ||
| /// - User lacks permissions to modify `path`. | ||
| /// - A parent of the given path doesn't exist and `recursive` is false. | ||
| /// - `path` already exists and `recursive` is false. | ||
| fn create_dir(state: &Cheatcodes, path: impl AsRef<Path>, recursive: bool) -> Result<Bytes, Bytes> { | ||
| let path = | ||
| state.config.ensure_path_allowed(path, FsAccessKind::Write).map_err(error::encode_error)?; | ||
| if recursive { fs::create_dir_all(path) } else { fs::create_dir(path) } | ||
| .map(|()| Bytes::new()) | ||
| .map_err(error::encode_error) | ||
| } | ||
|
|
There was a problem hiding this comment.
I expect fs to grow eventually so would like to move all of them to new file fs.rs
testdata/cheats/Fs.t.sol
Outdated
| // string memory path = "../testdata/fixtures/Dir"; | ||
|
|
||
| // { | ||
| // Cheats.DirEntry[] memory entries = cheats.readDir(path); |
There was a problem hiding this comment.
remembered this issue:
same error but turned out to be abi decoding related
but perhaps configured memory limit?
Motivation
Fixes #4797
Added to
Cheats.sol:TODO: read dir test fails due to memory allocation overflow, I'm not sure why
Solution