Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(anvil): treat 0 basefee as constant #5163

Merged
merged 1 commit into from Jun 15, 2023
Merged

fix(anvil): treat 0 basefee as constant #5163

merged 1 commit into from Jun 15, 2023

Conversation

Evalir
Copy link
Member

@Evalir Evalir commented Jun 15, 2023

Closes #5161

Treats base fee set at 0 as a constant and skips calculating a new basefee altogether if so.

@Evalir Evalir requested a review from mattsse June 15, 2023 18:29
mattsse
mattsse approved these changes Jun 15, 2023
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, lgtm

@mattsse mattsse merged commit fca0a6c into master Jun 15, 2023
18 checks passed
@mattsse mattsse deleted the evalir/treat-0-fee branch June 15, 2023 19:05
@holic
Copy link

holic commented Jun 15, 2023

thank you!

@holic holic mentioned this pull request Jun 15, 2023
Merged
@alvrs alvrs mentioned this pull request Jun 16, 2023
Merged
@holic holic mentioned this pull request Aug 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

anvil base fee increases to 1 after starting with 0 and sending many transactions
3 participants
@Evalir @holic @mattsse