Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(cli): revert temporary workaround to reset anvil base fee to 0 #1040

Merged
merged 3 commits into from Jun 16, 2023
Merged

chore(cli): revert temporary workaround to reset anvil base fee to 0 #1040

merged 3 commits into from Jun 16, 2023

Conversation

holic
Copy link
Member

@holic holic commented Jun 15, 2023 •
edited

Reverts #1039
Reverts #990

Anvil was patched with special handling for zero base fee: foundry-rs/foundry#5163

@changeset-bot
Copy link

changeset-bot bot commented Jun 15, 2023 •
edited

⚠️ No Changeset found

Latest commit: 58fdbd9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@alvrs alvrs changed the title Revert "fix(cli): temporary workaround to reset anvil base fee to 0" chore(cli): revert temporary workaround to reset anvil base fee to 0 Jun 15, 2023
@alvrs alvrs marked this pull request as ready for review June 15, 2023 19:40
@alvrs alvrs self-requested a review as a code owner June 15, 2023 19:40
@holic holic changed the title chore(cli): revert temporary workaround to reset anvil base fee to 0 Reverts "fix(cli): temporary workaround to reset anvil base fee to 0" Jun 15, 2023
@holic holic changed the title Reverts "fix(cli): temporary workaround to reset anvil base fee to 0" chore(cli): revert temporary workaround to reset anvil base fee to 0 Jun 15, 2023
@holic
Copy link
Member Author

holic commented Jun 15, 2023

weird that the PR title validator doesn't support reverts

@holic
Copy link
Member Author

holic commented Jun 15, 2023 •
edited

just waiting on a new foundry nightly before merging! https://github.com/foundry-rs/foundry/actions/workflows/release.yml

@alvrs alvrs merged commit b62be9d into main Jun 16, 2023
10 checks passed
@alvrs alvrs deleted the revert-1039-alvrs/anvil-fix branch June 16, 2023 16:56
@dk1a dk1a mentioned this pull request Jun 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvrs alvrs alvrs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@holic @alvrs