Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand the Actor and Item source field to contain more structured data #2504

Closed
aaclayton opened this issue Oct 20, 2023 · 0 comments
Closed
Assignees
Milestone

Comments

@aaclayton
Copy link
Contributor

aaclayton commented Oct 20, 2023

Suggest that the Source field which is currently a string field be expanded to be displayed read-only on the sheet with a configuration cog to open a mini config app for the source. Properties of the source configuration would be:

Source Data

  • Book (optional, a select input populated with a configured list of known sources)
  • Page (optional, a string in case some page numbers are non-numeric like "Appendix I")
  • Custom (optional, a custom string which overrides Book and Page)
  • UUID (optional, a UUID which represents an upstream source of the data flags.core.sourceId)
  • Creative Commons (boolean, a checkmark to keep track of content which is has a creative commons license. Alternatively a license dropdown field if we wanted to support multiple options like CC, OGL, ORC, custom etc...)

Module Extensibility

3rd party modules like "Tome of Beasts" or "Flee Mortals" could register themselves to DND5E.CONFIG.SOURCES in order to appear in the Book dropdown.

Benefits

  • Present source references in a standardized format
  • Useful for content creators building adventures with imported data to customize content sources for custom import behaviors
  • Useful for filtering content in a future compendium browser UI to identify content from a particular book
  • Licensing rights are important and the future of D&D may involve pretty mixed content with CC/SRD/ORC/Unlicensed all in play

Data Migration

The data migration to support this would be relatively easy. The current source string would be migrated to source.custom.

@arbron arbron added this to the D&D5E 2.4.0 milestone Oct 21, 2023
@arbron arbron self-assigned this Oct 29, 2023
arbron added a commit to arbron/dnd5e that referenced this issue Oct 29, 2023
arbron added a commit to arbron/dnd5e that referenced this issue Oct 29, 2023
arbron added a commit to arbron/dnd5e that referenced this issue Oct 29, 2023
arbron added a commit to arbron/dnd5e that referenced this issue Oct 31, 2023
arbron added a commit to arbron/dnd5e that referenced this issue Nov 9, 2023
arbron added a commit to arbron/dnd5e that referenced this issue Nov 9, 2023
arbron added a commit to arbron/dnd5e that referenced this issue Nov 9, 2023
arbron added a commit to arbron/dnd5e that referenced this issue Nov 13, 2023
arbron added a commit to arbron/dnd5e that referenced this issue Nov 13, 2023
arbron added a commit to arbron/dnd5e that referenced this issue Nov 14, 2023
arbron added a commit that referenced this issue Nov 14, 2023
[#2504] Implement editor for source data
@arbron arbron closed this as completed Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants