Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#2504] Convert source on items & actors into object #2534

Merged
merged 2 commits into from
Oct 31, 2023
Merged

[#2504] Convert source on items & actors into object #2534

merged 2 commits into from
Oct 31, 2023

Conversation

arbron
Copy link
Collaborator

@arbron arbron commented Oct 29, 2023 •
edited

First part of #2504 that migrates the data structure to an object. This updates the existing templates to display and reference source.custom so a future PR can add a source configuration app.

{
  book: "",
  page: "",
  custom: "",
  uuid: "",
  license: ""
}

@arbron arbron added this to the D&D5E 2.4.0 milestone Oct 29, 2023
@arbron arbron self-assigned this Oct 29, 2023
@arbron arbron changed the title [#2504] Convert source on items into object [#2504] Convert source on items & actors into object Oct 29, 2023
aaclayton
aaclayton requested changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@aaclayton aaclayton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me, thanks @arbron. Get any feedback from @Fyorl but this looks able to move forward.

module/data/actor/npc.mjs Outdated Show resolved Hide resolved
module/data/shared/source-field.mjs Outdated Show resolved Hide resolved
module/data/shared/source-field.mjs Show resolved Hide resolved
@Fyorl Fyorl merged commit 60714c3 into foundryvtt:2.4.x Oct 31, 2023
@arbron arbron deleted the source/data branch October 31, 2023 20:50
@kgar kgar mentioned this pull request Nov 6, 2023
Merged
56 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaclayton aaclayton aaclayton requested changes

@Fyorl Fyorl Fyorl approved these changes

Assignees

@arbron arbron

Labels
feature request
Projects
None yet
Milestone
D&D5E 2.4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arbron @Fyorl @aaclayton