Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically open damage application tray for new rolls #3291

Closed
arbron opened this issue Mar 21, 2024 · 1 comment · Fixed by #3546
Closed

Automatically open damage application tray for new rolls #3291

arbron opened this issue Mar 21, 2024 · 1 comment · Fixed by #3546
Assignees
@arbron
Labels
ux User experience related features or bugs
Milestone
D&D5E 3.2.0

Comments

@arbron
Copy link
Collaborator

arbron commented Mar 21, 2024 •
edited
Loading

It would be great if the damage application tray would pop open by default for newly created damage rolls so GMs don't have to open it every time.
@arbron arbron added the ux User experience related features or bugs label Mar 21, 2024
@krbz999
Copy link
Contributor

krbz999 commented Mar 21, 2024

Same for effects.

@MangoFVTT MangoFVTT mentioned this issue Mar 22, 2024
Closed
@arbron arbron self-assigned this May 9, 2024
@arbron arbron added this to the D&D5E 3.2.0 milestone May 9, 2024
arbron added a commit that referenced this issue May 9, 2024
@arbron
[#3291] Add setting to control chat card tray expansion
6f71844 
Adds a new setting allowing setting the initial expanded state of
damage & effect application trays in chat cards. The settings are
"Expand All" and "Collapse All" plus "Collapse Older", which
expands newly created cards but collapses any cards more than five
minutes old.

To better support the expanding trays, a new CardTrayElement has
been added which adds support for the `open` attribute on card
trays to explicitly control its behavior. This attribute matches
the behavior of the `open` attribute on `<details>` elements, so
adding or removing the attribute will open and close the tray, and
toggling the `open` property will cause the attribute to be added
or removed. The tray also fires off a `toggle` event that matches
the one fired by `<details>`.
arbron added a commit that referenced this issue May 9, 2024
@arbron
[#3291] Add setting to control chat card tray expansion
d6b0811 
Adds a new setting allowing setting the initial expanded state of
damage & effect application trays in chat cards. The settings are
"Expand All" and "Collapse All" plus "Collapse Older", which
expands newly created cards but collapses any cards more than five
minutes old.

To better support the expanding trays, a new CardTrayElement has
been added which adds support for the `open` attribute on card
trays to explicitly control its behavior. This attribute matches
the behavior of the `open` attribute on `<details>` elements, so
adding or removing the attribute will open and close the tray, and
toggling the `open` property will cause the attribute to be added
or removed. The tray also fires off a `toggle` event that matches
the one fired by `<details>`.
arbron added a commit that referenced this issue May 10, 2024
@arbron
[#3291] Add jsDoc comment
727c72c
arbron added a commit that referenced this issue May 10, 2024
@arbron
Merge pull request #3546 from foundryvtt/chat-trays
035bd00 
[#3291] Add setting to control chat card tray expansion
@arbron arbron closed this as completed May 10, 2024
@arbron arbron mentioned this issue May 10, 2024
Merged
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arbron arbron

Labels
ux User experience related features or bugs
Projects
None yet
Milestone
D&D5E 3.2.0
Development

Successfully merging a pull request may close this issue.

[#3291] Add setting to control chat card tray expansion foundryvtt/dnd5e
2 participants
@arbron @krbz999