Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In character sheet, split special senses with semi-colon #968

Closed
aaclayton opened this issue Jan 22, 2021 · 1 comment
Closed

In character sheet, split special senses with semi-colon #968

aaclayton opened this issue Jan 22, 2021 · 1 comment
Labels
bug Functionality which is not working as intended
Milestone
D&D5E 2.4.0

Comments

@aaclayton
Copy link
Contributor

Originally in GitLab by @CDeenen

On the attributes page of the character sheet you can add custom attributes with the 'special' field such as for languages, damage immunities, etc.
For pretty much all of these, you can split multiple attributes with a semi-colon, however, this does not work for 'Senses'. Could this be added?
@Fyorl Fyorl added the bug Functionality which is not working as intended label Jul 3, 2023
@Hoppyhob
Copy link
Contributor

Hey I can work on this issue.

Hoppyhob added a commit to Hoppyhob/dnd5e that referenced this issue Sep 10, 2023
@Hoppyhob
[foundryvtt#968] Update base-sheet.mjs
1695fae 
Updated base-sheet.mjs _getSenses(systemData) to use similar method to _prepareTraits(systemData) to split special senses into a senses.customN instead of under senses.special
Hoppyhob added a commit to Hoppyhob/dnd5e that referenced this issue Sep 10, 2023
@Hoppyhob
[foundryvtt#968] Update base-sheet.mjs
4f80368 
Updated base-sheet.mjs _getSenses(systemData) to use similar method to _prepareTraits(systemData) to split special senses into a senses.customN instead of under senses.special
@Hoppyhob Hoppyhob mentioned this issue Sep 10, 2023
Merged
@Fyorl Fyorl added this to the D&D5E 2.4.0 milestone Oct 13, 2023
Fyorl pushed a commit that referenced this issue Oct 13, 2023
@Hoppyhob
[#968] Split custom senses on semi-colon (#2471)
9b285e2
@Fyorl Fyorl closed this as completed Oct 13, 2023
MaxPat931 added a commit to MaxPat931/5e-statblock-importer that referenced this issue Oct 18, 2023
@MaxPat931
Allow for custom senses, ignore PP
ee9c946 
Handle multiple custom Senses, split with a semicolon per `foundryvtt/dnd5e#968 and ignore Passive Perception since the system calculates that on its own
MaxPat931 added a commit to MaxPat931/5e-statblock-importer that referenced this issue Oct 18, 2023
@MaxPat931
Merge pull request #1 from MaxPat931/custom-senses
64e0ed0 
Handle multiple custom Senses, split with a semicolon per `foundryvtt/dnd5e#968 and ignore Passive Perception since the system calculates that on its own
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Functionality which is not working as intended
Projects
None yet
Milestone
D&D5E 2.4.0
Development

No branches or pull requests
3 participants
@Fyorl @aaclayton @Hoppyhob