Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#968] Update base-sheet.mjs #2471

Merged
merged 1 commit into from
Oct 13, 2023
Merged

[#968] Update base-sheet.mjs #2471

merged 1 commit into from
Oct 13, 2023

Conversation

Hoppyhob
Copy link
Contributor

Closes #968
Modified _getSenses(systemData)
Removes senses.special
Adds a senses.customN for each special senses separated by a semi-colon (N being the index starting from 1)

Updated base-sheet.mjs _getSenses(systemData) to use similar method to _prepareTraits(systemData) to split special senses into a senses.customN instead of under senses.special
Copy link
Contributor

@aaclayton aaclayton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and matches the way that other custom traits are handled. @Fyorl if this looks good to you feel free to merge in.

@Fyorl Fyorl changed the base branch from 2.3.x to 2.4.x October 13, 2023 16:37
@Fyorl Fyorl added this to the D&D5E 2.4.0 milestone Oct 13, 2023
@Fyorl Fyorl merged commit 9b285e2 into foundryvtt:2.4.x Oct 13, 2023
@Hoppyhob Hoppyhob deleted the 2.3.x branch February 3, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants