-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#2135, #2136] Add multi editor to make additional descriptions editable #2137
Conversation
I'm interested in using this for #1696 once this PR goes through, it would make for a much neater UX/UI imo. |
…l descriptions editable
I think my only hangup at the moment is that I'm not sold on the UI of selecting a description to edit via a drop-down. In some discussions around this feature it was suggested that a slide-toggle might be nice for most cases where there's only two descriptions to choose from. Something like So first maybe we could consider whether we need the Alternatively, because I also quite liked what @ccjmk proposed in #1696 with the ability to see all descriptions at once, we could potentially do something like an accordion style UI (maybe using the Having multiple editors in the same tab can be quite awkward to style, so I would propose that we side-step the issue by having the edit button instead pop out a separate editor dialog that is edit-only mode (similar to how journal page editing works.) Obviously this is entirely subjective so I am not insisting on anything here but am interested to see if we can iterate on this design at all. |
This seems like a use case for tabs. However, if a pop-out text editor would allow collaboration that is to me 100% the ideal. |
@Fyorl Here is a quick prototype of showing all descriptions inline and replacing the whole tab with an editor: Multiple.Inline.movOn locked sheets it hides the first header to avoid clutter: ![]() |
Looks pretty good to me. One minor point of feedback would be to have the edit button always visible so it's more obvious what you need to do in order to edit the description rather than having to hover over it to find out. Otherwise I think we should be good to proceed in this direction. |
Closed in favor of a new PR: #2137 |
Creates a new
{{multiEditor}}
handlebar helper that takes configuration objects (prepared by the{{source}}
helper) to display multiple descriptions within a single editor:Editor.Target.Selection.mov
Also displays the contents of
system.description.chat
for item chat messages if present to allow for custom chat description.Resolves #2135
Resolves #2136