Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dnd5e 2.4.x Compatibility Release 1 #32

Merged
merged 30 commits into from
Nov 17, 2023
Merged

Dnd5e 2.4.x Compatibility Release 1 #32

merged 30 commits into from
Nov 17, 2023

Conversation

kgar
Copy link
Owner

@kgar kgar commented Nov 6, 2023

#31

Ensures Tidy 5e Sheets is ready for the 2.4.x dnd5e release.

Review these PRs and determine what work needs to be done to prepare Tidy 5e for 2.4.x:

Add to this list of PRs if more PRs are included in the milestone later: https://github.com/foundryvtt/dnd5e/pulls?q=is%3Apr+milestone%3A%22D%26D5E+2.4.0%22+

To Do:

  • Implement Item Sheet for item type "race"

@kgar kgar self-assigned this Nov 6, 2023
@kgar kgar added the dnd5e This relates to dnd5e system updates or issues label Nov 6, 2023
…e enough breaking changes that it will need to set the minimum to 2.4.0.

Added Race item type.

Swapped out descriptionHTML for enriched.description
@kgar kgar added the enhancement New feature or request label Nov 15, 2023
kgar and others added 20 commits November 15, 2023 15:36
…that's this module's job to set the default sheet.
Adjusted Source to truncate its source label span and to respect line height and height styles from parent components.

Made necessary changes to items core styles to support flex child truncation.
…environment.

Updated origin summary config to use the source label prop.
…e module while doing development.

Turned off the automatic browser URL open when starting the dev server.
…s prevents there from being just empty space when there's no source at the moment. At least, it invites users to interact with it.
…or actor sheet headers.

Plugged in InlineSource to NPC sheet.
kgar and others added 4 commits November 16, 2023 16:13
…aded it to handle characters and NPCs correctly.
…l handling which requires they have a race and that the dialog is called in a special way.
…y when the character has a background or race, respectively.
@kgar kgar changed the title Ensure Dnd5e 2.4.x readiness Dnd5e 2.4.x Compatibility Release 1 Nov 17, 2023
@kgar
Copy link
Owner Author

kgar commented Nov 17, 2023

Gotta stop somewhere and get this out the door

@kgar kgar merged commit c37b39b into main Nov 17, 2023
1 check passed
@kgar kgar deleted the dnd5e-2.4.x-readiness branch November 17, 2023 02:26
@kgar kgar mentioned this pull request Nov 17, 2023
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dnd5e This relates to dnd5e system updates or issues enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant