-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dnd5e 2.4.x Compatibility Release 1 #32
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d5e-2.4.x-readiness
…d5e-2.4.x-readiness
…e enough breaking changes that it will need to set the minimum to 2.4.0. Added Race item type. Swapped out descriptionHTML for enriched.description
…d5e-2.4.x-readiness
…that's this module's job to set the default sheet.
Adjusted Source to truncate its source label span and to respect line height and height styles from parent components. Made necessary changes to items core styles to support flex child truncation.
…environment. Updated origin summary config to use the source label prop.
…e module while doing development. Turned off the automatic browser URL open when starting the dev server.
…s prevents there from being just empty space when there's no source at the moment. At least, it invites users to interact with it.
…info is gathered.
…or actor sheet headers. Plugged in InlineSource to NPC sheet.
…adlock is locked.
…aded it to handle characters and NPCs correctly.
…l handling which requires they have a race and that the dialog is called in a special way.
…y when the character has a background or race, respectively.
Gotta stop somewhere and get this out the door |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#31
Ensures Tidy 5e Sheets is ready for the 2.4.x dnd5e release.
Review these PRs and determine what work needs to be done to prepare Tidy 5e for 2.4.x:
system.attributes.ac.bonus
foundryvtt/dnd5e#2520Add to this list of PRs if more PRs are included in the milestone later: https://github.com/foundryvtt/dnd5e/pulls?q=is%3Apr+milestone%3A%22D%26D5E+2.4.0%22+
To Do: