Add spellLevel to measured template flags #2239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krbz999
reviewed
Mar 19, 2023
| @@ -48,6 +48,7 @@ export default class AbilityTemplate extends MeasuredTemplate { | |||
| fillColor: game.user.color, | |||
| flags: { dnd5e: { origin: item.uuid } } | |||
| }; | |||
| if ( item.type === "spell" ) foundry.utils.mergeObject(templateData.flags, {"dnd5e.spellLevel": item.system.level}); | |||
There was a problem hiding this comment.
mergeObject might be a bit overkill here, since flags.dnd5e always exists. 🤔
There was a problem hiding this comment.
I just followed the same pattern already established here:
dnd5e/module/documents/item.mjs
Line 842 in bdc76e2
Fyorl
approved these changes
Sep 7, 2023
56 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2215