Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2279] Update context on resting #2320

Merged
merged 5 commits into from
Sep 7, 2023

Conversation

krbz999
Copy link
Contributor

@krbz999 krbz999 commented May 26, 2023

Adds isRest: true to actor and item updates context when resting.

Closes #2279.

Add `isRest: true` to actor update context when resting
and introduce `DND5E.grittyRestDuration`.
Copy link
Contributor

@Fyorl Fyorl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a little awkward to have only the gritty rest duration configurable. I have an alternative proposal below.

module/documents/actor/actor.mjs Outdated Show resolved Hide resolved
module/config.mjs Outdated Show resolved Hide resolved
@Fyorl Fyorl changed the base branch from 2.2.x to 2.4.x September 7, 2023 13:45
@Fyorl Fyorl added this to the D&D5E 2.4.0 milestone Sep 7, 2023
@krbz999 krbz999 changed the title [#2203, #2279] Gritty rest duration configuration and update context on resting [#2279] Update context on resting Sep 7, 2023
@Fyorl Fyorl merged commit 161b3d0 into foundryvtt:2.4.x Sep 7, 2023
@krbz999 krbz999 deleted the gritty-rest-duration branch September 7, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants