Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2245] Stack consumables on the Group actor sheet #2424

Merged
merged 2 commits into from
Nov 1, 2023

Conversation

krbz999
Copy link
Contributor

@krbz999 krbz999 commented Aug 12, 2023

... This is getting silly.

Eventually the group sheet should simply extend the Actor5e sheet, or base system sheet implementation should be separated into an abstract utility sheet that can get mixed into specific actor sheets, possibly splitting them in two groups; 'living sheets' (character, npc, vehicle) and 'other sheets' (group).

Closes #2245

@krbz999 krbz999 changed the base branch from master to 2.4.x October 20, 2023 19:39
@Fyorl
Copy link
Contributor

Fyorl commented Nov 1, 2023

Eventually the group sheet should simply extend the Actor5e sheet, or base system sheet implementation should be separated into an abstract utility sheet that can get mixed into specific actor sheets, possibly splitting them in two groups; 'living sheets' (character, npc, vehicle) and 'other sheets' (group).

We keep talking about this but never raised an issue so I have done so now #2545. It would also work as a mixin if we want.

@Fyorl Fyorl added this to the D&D5E 2.4.0 milestone Nov 1, 2023
@Fyorl Fyorl merged commit c506a25 into foundryvtt:2.4.x Nov 1, 2023
@krbz999 krbz999 deleted the group-sheet-drop-consumable branch November 1, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Group actor sheet does not stack consumables
2 participants