[#2446] Toggle inspiration on the header element #2447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fyorl
approved these changes
Oct 25, 2023
There was a problem hiding this comment.
Sorry for reaching in and rewriting your PR, but it was so small that I felt it wasn't worth the back-and-forth. I didn't want us to use rollable here as it's a UI cue that we have established that implies something will be rolled, but inspiration isn't rolled. I've used <label> here as the typical way to connect some label text to checkbox. Technically <h4> is not valid inside a <label> but I didn't want to mess with the styles too much for this small PR.
56 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2446