Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework build scripts to avoid the use of gulp #2458

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Conversation

arbron
Copy link
Collaborator

@arbron arbron commented Sep 6, 2023

Remove gulp and related dependencies to avoid outstanding security vulnerabilities and clean up the CLI a bit.

@arbron arbron requested a review from Fyorl September 6, 2023 00:47
@arbron arbron self-assigned this Sep 6, 2023
@Varriount
Copy link
Contributor

Just curious, why?

@arbron
Copy link
Collaborator Author

arbron commented Oct 20, 2023

Just curious, why?

Vulnerabilities with Gulp dependencies. Since it hasn't had any new releases since 2019 the chance of those being fixed doesn't seem high.

@Fyorl
Copy link
Contributor

Fyorl commented Oct 20, 2023

I just want to note that, since gulp is a dev dependency, users are not exposed to any of these vulnerabilities, so it is not a super high priority or anything. It does mean there's a fair bit of noise when running npm audit though, meaning we could miss more serious vulnerabilities. Since we can replace gulp fairly easily in this case then we might as well.

utils/packs.mjs Outdated Show resolved Hide resolved
utils/packs.mjs Outdated Show resolved Hide resolved
utils/packs.mjs Show resolved Hide resolved
@Fyorl
Copy link
Contributor

Fyorl commented Oct 30, 2023

One additional comment is that there seems to have been a critical vulnerability raised against @babele/traverse so feel free to bump some dependency versions additionally, or fix it with npm audit before we merge this.

@arbron arbron merged commit 5fe4c2b into foundryvtt:2.4.x Oct 30, 2023
@arbron arbron deleted the no-gulp branch October 30, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants