Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#2515] Fix warning from referenced active effect label #2516

Merged
merged 1 commit into from
Oct 26, 2023
Merged

[#2515] Fix warning from referenced active effect label #2516

merged 1 commit into from
Oct 26, 2023

Conversation

arbron
Copy link
Collaborator

@arbron arbron commented Oct 23, 2023

Changes references to ActiveEffect#label to use ActiveEffect#name and adds a temporary shim to ActiveEffect5e on v10 to support that property.

@arbron arbron added the bug Functionality which is not working as intended label Oct 23, 2023
@arbron arbron added this to the D&D5E 2.4.0 milestone Oct 23, 2023
@arbron arbron requested a review from Fyorl October 23, 2023 21:25
@arbron arbron self-assigned this Oct 23, 2023
@Fyorl Fyorl merged commit ab7b7bd into foundryvtt:2.4.x Oct 26, 2023
@kgar kgar mentioned this pull request Nov 6, 2023
Merged
56 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fyorl Fyorl Fyorl approved these changes

Assignees

@arbron arbron

Labels
bug Functionality which is not working as intended
Projects
None yet
Milestone
D&D5E 2.4.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@arbron @Fyorl