[#2220] Add SizeAdvancement #2542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
8 tasks
arbron
force-pushed
the
advancement/size
branch
from
e6e31c3
to
c2c421e
Compare
Fyorl
requested changes
Nov 6, 2023
|
|
||
| /** @inheritdoc */ | ||
| get levels() { | ||
| return [0]; |
There was a problem hiding this comment.
I thought this wouldn't apply to advancements granted by non-class and non-subclass items?
There was a problem hiding this comment.
This is still relevant, it just refers to character level rather than class level. 0 here indicates that this should be applied regardless of current character level.
Comment on lines
4
to
7
| <div class="form-group"> | ||
| <label>{{localize "DND5E.AdvancementHint"}}</label> | ||
| <textarea name="configuration.hint">{{configuration.hint}}</textarea> | ||
| </div> |
There was a problem hiding this comment.
I saw in your screenshot that this looked quite cramped. It would be nicer to have the textarea able to fill the full width I think.
…e is possible, adjust styling
56 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces the size advancement for races:
Closes #2220