Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#342] Apply senses/movement to actor when race is added #2556

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

arbron
Copy link
Collaborator

@arbron arbron commented Nov 6, 2023

  • Movement types and senses are applied automatically, assuming the current value on the actor isn't already higher
  • Creature type isn't applied yet because we don't have it displayed on the actor, I'll handle that in another PR
  • When deleting the race, movement and senses are unapplied if the value is equal to that on the race (so we don't get rid of values if the player has changed them)
  • We now prompt when removing backgrounds & races with advancement just like with classes & subclasses
  • If the player unchecks "Remove advancement changes" when deleting a race, it will not unapply any of the direct changes

module/applications/actor/base-sheet.mjs Outdated Show resolved Hide resolved
module/data/item/race.mjs Outdated Show resolved Hide resolved
@arbron
Copy link
Collaborator Author

arbron commented Nov 7, 2023

@Fyorl Since creature type on PCs has been merged, I've added support for that into this PR.

@arbron arbron requested a review from Fyorl November 7, 2023 19:59
module/data/actor/character.mjs Outdated Show resolved Hide resolved
@arbron arbron merged commit 81b70cf into foundryvtt:2.4.x Nov 7, 2023
@arbron arbron deleted the types/race-apply branch November 7, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants