Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2567, #2569] Add status indicator to accordions, fix jump on sheet re-render #2573

Merged
merged 4 commits into from
Nov 13, 2023

Conversation

arbron
Copy link
Collaborator

@arbron arbron commented Nov 8, 2023

Accordion.Indicator.mov

@arbron arbron added bug Functionality which is not working as intended ui User interface related features or bugs labels Nov 8, 2023
@arbron arbron added this to the D&D5E 2.4.0 milestone Nov 8, 2023
@arbron arbron requested a review from Fyorl November 8, 2023 22:10
@arbron arbron self-assigned this Nov 8, 2023
@krbz999
Copy link
Contributor

krbz999 commented Nov 8, 2023

This is incredibly minor, but can we have the accordion transition time match the time for item details on the actor sheets (which are noticeably faster).

module/applications/accordion.mjs Outdated Show resolved Hide resolved
templates/items/parts/item-description.hbs Show resolved Hide resolved
@arbron arbron requested a review from Fyorl November 13, 2023 15:31
@arbron
Copy link
Collaborator Author

arbron commented Nov 13, 2023

Screenshot 2023-11-13 at 07 31 38

@arbron arbron merged commit 2a671e6 into foundryvtt:2.4.x Nov 13, 2023
@arbron arbron deleted the accordion branch November 13, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Functionality which is not working as intended ui User interface related features or bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants