Use reflection to support both versions of Android Studio #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tasomaniac
force-pushed
the
taso/support-as-3.4
branch
3 times, most recently
from
c0457ca
to
173ea87
Compare
fourlastor
reviewed
Jan 31, 2019
| configure(project, testVariants, extension) | ||
| } | ||
| } | ||
| is AppPlugin -> { | ||
| project.extensions.findByType(AppExtension::class.java).run { | ||
| project.extensions.findByType(AppExtension::class.java)?.run { |
| val mergeAssets = method(taskProvider, MergeSourceSetFolders::class.java, "get").invoke(taskProvider) | ||
| val outputDirProvider = method(mergeAssets, Provider::class.java, "getOutputDir").invoke(mergeAssets) | ||
| (outputDirProvider.get() as Directory).asFile | ||
| } catch (ignored: Exception) { |
There was a problem hiding this comment.
can we have a more specific catched exception here?
tasomaniac
force-pushed
the
taso/support-as-3.4
branch
from
173ea87
to
c471b7a
Compare
fourlastor
approved these changes
Jan 31, 2019
|
Thank you @tasomaniac! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android Studio did a break change with the public task API on Android Studio 3.4.
This breaks the compatibility between Pickle and AS 3.4
If the plugin would've been in Groovy, this would be 1 line fix. Kotlin is not so dynamic
Anyways, here is a fix to support all versions. It uses reflection utilities from Gradle to access new APIs. If they're not available, it fallbacks to original.
Fixes #4