Update dependencies #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tasomaniac
commented
Feb 1, 2019
| @@ -92,12 +92,12 @@ class PicklePlugin : Plugin<Project> { | |||
| project.plugins.all { | |||
| when (it) { | |||
| is LibraryPlugin -> { | |||
| project.extensions.findByType(LibraryExtension::class.java).run { | |||
| project.extensions.findByType(LibraryExtension::class.java)?.run { | |||
There was a problem hiding this comment.
This is now required. Btw, I can also do !!. What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the last PR #7, I think I was building and testing with the local Gradle distribution. It is still backward compatible but needs to be compiled with later versions.
The problem is that
asFilewas introduced in Gradle 4.2. Since that is only used for the hacky reflection for Android Plugin version 3.4+, that should all be fine.I could've just upgraded to 4.2 but decided why not upgrading to latest versions. So here we go.