Add JTS core as a dependency #20
Conversation
|
CC: @isaacbrodsky |
|
CC: @nrabinowitz |
|
This looks good to me but I'll let @isaacbrodsky sign off |
|
@nrabinowitz could you approve the workflow on this PR so we get the CI results? Thanks |
Pull Request Test Coverage Report for Build #15Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Thank you for contributing this fix!
I'd recommend also updating the pom.xml to Presto 0.286, which is the version I tested with.
I was able to successfully start the server with the h3-presto plugin using this patch and run a test query:
(Note this used a customized Dockerfile with the h3-presto plugin added to it)
docker run -p 8080:8080 --rm -it presto
presto> select h3_latlng_to_cell(0,0,0);
_col0
--------------------
578536630256664575
(1 row)
Query 20240327_220914_00002_2x9k7, FINISHED, 1 node
Splits: 17 total, 17 done (100.00%)
[Latency: client-side: 305ms, server-side: 266ms] [0 rows, 0B] [0 rows/s, 0B/s]
Previously, this was added as a transitive dependency, which made it susceptible to breaking whenever Presto would upgrade its JTS library. It's now included and shaded to make it resilient to Presto upgrades.
|
Thank you @isaacbrodsky, I have updated the Presto dependency to 0.286. |
Here's the Dockerfile and instructions I used to test #20.
Previously, this was added as a transitive dependency, which made it susceptible to breaking whenver Presto would upgrade its JTS library. It's now included and shaded to make it resilient to Presto upgrades.