Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add sample Docker file #21

Merged
merged 1 commit into from
Mar 28, 2024
Merged

add sample Docker file #21

merged 1 commit into from
Mar 28, 2024

Conversation

isaacbrodsky
Copy link
Contributor

Here's the Dockerfile and instructions I used to test #20.

@coveralls
Copy link

Pull Request Test Coverage Report for Build #13

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.561%
Totals Coverage Status
Change from base Build #11: 0.0%
Covered Lines: 217
Relevant Lines: 237
💛 - Coveralls

@isaacbrodsky
Copy link
Contributor Author

@nrabinowitz @ibgreen Please take a look

nrabinowitz
nrabinowitz reviewed Mar 28, 2024
View reviewed changes
contrib/docker/etc/node.properties
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to look this up: https://prestodb.io/docs/0.285/installation/deployment.html#node-properties

@nrabinowitz nrabinowitz merged commit 78a0387 into foursquare:main Mar 28, 2024
4 checks passed
@isaacbrodsky isaacbrodsky deleted the sample-docker branch March 28, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrabinowitz nrabinowitz nrabinowitz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@isaacbrodsky @coveralls @nrabinowitz