Resolves #69 - in which or(where, whereOpt(None)) creates a bad query

[ktoso]

Hello again,
It's been some time since I found #69, but since it's now Christmas 🎄 I found some time and came back to this and fixed the issue. :-)

Reminding the problem again:

// what was the problem:
Venue.where(_.or(_.where(_.email eqs "   "), _.where(None)(_.neverMind eqs _)))

// we got:
{"$or": [{"email": "   "}, {  } ]}
                 ^ false     ^ always true => we fetch the entire collection

// what we get with this fix:
{"$or": [ {"email": "   "} ]} // as expected

There are tests for both cases attached (Some/None) and a fix.

I have added a method to AndCondition, if that's something you'd rather want to keep without methods please let me know where I should move this isEmpty method (or don't do it as a method?).

Thanks again for the great library,
Looking forward to the 2.0 / 2.10 releases!

Konrad

[jliszka]

Thanks! Sorry, I had put the fix in the v2 branch awhile back, forgot to port it back.

[ktoso]

No problem :) Glad to hear it's fixed in 2.0 already.

Thanks for merging!