Query with optional where clause, in or clause, generates wrong query

[ktoso]

Hey guys,
seems we encountered a bug in building a specific query, example bellow:

MyMeta
      .or(
        _.where(_.things in List(thing)),
        _.whereOpt(additionalThing))(_.additionalThings in List(_))
      )

Which generates such query (additionalThing = None):

... "$or": [ { "things" : { "$in" : [ "thingA"]}} , { }]},  ...

What we don't like here is the { } part in the or. We'd rather just have it left out.
This makes the query fetch the entire collection so we had to fallback to manual building of or if it's needed.

Cheers and thanks for the great lib :)
Konrad

[jliszka]

Aha, thanks! Will fix.

Regards,
Jason

On Wed, Nov 7, 2012 at 8:09 AM, Konrad Malawski notifications@github.comwrote:

Hey guys,
seems we encountered a bug in building a specific query, example bellow:

MyMeta
.or(
.where(.things in List(thing)),
.whereOpt(additionalThing))(.additionalThings in List(_))
)

Which generates such query (additionalThing = None):

... "$or": [ { "postal_codes" : { "$in" : [ "95206"]}} , { }]}, ...

What we don't like here is the { } part in the or. We'd rather just have
it left out.
This impacts index use so we had to fallback to manual building of or if
it's needed.

Cheers and thanks for the great lib :)
Konrad

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/69.