Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimiation is not optimal #79

Closed
kernighan opened this issue Jul 21, 2022 · 3 comments
Closed

Optimiation is not optimal #79

kernighan opened this issue Jul 21, 2022 · 3 comments

Comments

@kernighan
Copy link

Imported a MIDI, the resulting track has:

'r1r2r8.'

Optimization should have at least reduced this to:

'r1.r8.'
@kernighan
Copy link
Author

I suspect that the optimizer is treating rests the same way as notes. I.e., it treats "r1r2" the same as "c1c2" but they should be handled differently since rests can be combined in an optimal fashion.

fourthline added a commit that referenced this issue Aug 17, 2022
@fourthline
tickTable拡張 #79
446df44
@fourthline
Copy link
Owner

446df44
Before:

  • c1&c2&c8.
  • r1r2r8.

After:

  • c1.&c8.
  • r1.r8.

etc...

@fourthline
Copy link
Owner

Released in v1.2.80

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kernighan @fourthline