Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make acquire compression configurable #185

Merged
merged 6 commits into from
Jul 19, 2024

Conversation

Horofic
Copy link
Contributor

@Horofic Horofic commented Jul 10, 2024

Make tar and zip compression output configurable by supplying a --compress-method argument as mentioned in #182

Additionally, some tests have been adjusted to account for this change.

@Horofic Horofic requested a review from pyrco July 10, 2024 11:23
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 4 lines in your changes missing coverage. Please review.

Project coverage is 44.60%. Comparing base (c84dfdf) to head (bd2cfe3).

Files Patch % Lines
acquire/utils.py 42.85% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #185      +/-   ##
==========================================
+ Coverage   43.37%   44.60%   +1.23%     
==========================================
  Files          26       26              
  Lines        3375     3394      +19     
==========================================
+ Hits         1464     1514      +50     
+ Misses       1911     1880      -31     
Flag Coverage Δ
unittests 44.60% <85.71%> (+1.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

acquire/utils.py Show resolved Hide resolved
@Horofic Horofic requested a review from pyrco July 17, 2024 12:06
acquire/utils.py Outdated Show resolved Hide resolved
acquire/utils.py Outdated Show resolved Hide resolved
@Horofic Horofic requested a review from pyrco July 18, 2024 07:36
Copy link
Contributor

@pyrco pyrco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but the testcases now fail

acquire/utils.py Outdated Show resolved Hide resolved
@Horofic Horofic requested a review from pyrco July 18, 2024 12:56
pyrco
pyrco previously approved these changes Jul 18, 2024
@Horofic Horofic merged commit d7dd277 into main Jul 19, 2024
19 of 20 checks passed
@Horofic Horofic deleted the DIS-3291_configurable-compression branch July 19, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants