Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve newlines when removing comments #43

Merged
merged 2 commits into from
Aug 4, 2023
Merged

Conversation

Schamper
Copy link
Member

@Schamper Schamper commented Aug 2, 2023

So that the line number remains accurate.

Also, actually fix the line number to be accurate :) it was off by one.

Fixes #31

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #43 (4574ea3) into main (38d332f) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #43   +/-   ##
=======================================
  Coverage   88.23%   88.23%           
=======================================
  Files          20       20           
  Lines        1709     1709           
=======================================
  Hits         1508     1508           
  Misses        201      201           
Flag Coverage Δ
unittests 88.23% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
dissect/cstruct/parser.py 71.42% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

dissect/cstruct/parser.py Outdated Show resolved Hide resolved
@Schamper Schamper requested a review from Poeloe August 4, 2023 10:13
tests/test_parser.py Show resolved Hide resolved
@Schamper Schamper requested a review from Poeloe August 4, 2023 11:06
Copy link

@Poeloe Poeloe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Schamper Schamper merged commit f9a9f86 into main Aug 4, 2023
18 checks passed
@Schamper Schamper deleted the preserve-comment-newlines branch August 4, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stripping comments does not preserve line numbers
2 participants