Move value parsing into its own function #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #18 +/- ##
==========================================
+ Coverage 52.18% 52.44% +0.25%
==========================================
Files 4 4
Lines 389 389
==========================================
+ Hits 203 204 +1
+ Misses 186 185 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Miauwkeru
requested changes
Jul 28, 2023
Comment on lines
+510
to
+515
| while data.tell() < data_len: | ||
| string = read_null_terminated_wstring(data) | ||
| if string == "": | ||
| break | ||
|
|
||
| multi_string.append(string) |
There was a problem hiding this comment.
Suggested change
| while data.tell() < data_len: | |
| string = read_null_terminated_wstring(data) | |
| if string == "": | |
| break | |
| multi_string.append(string) | |
| while string := read_null_terminated_wstring(data): | |
| multi_string.append(string) |
Wouldn't something like this do the same thing?
There was a problem hiding this comment.
Wouldn't that just error at the end of the data?
There was a problem hiding this comment.
I also don't intend to make much changes to how the function works.
Miauwkeru
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.