Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SMB filesystem support #331

Merged
merged 8 commits into from
Aug 17, 2023
Merged

Added SMB filesystem support #331

merged 8 commits into from
Aug 17, 2023

Conversation

Paradoxis
Copy link
Contributor

@Paradoxis Paradoxis commented Jul 27, 2023

Added SMB filesystem support which allows users to use dissect's tools remotely

Depends on some QOL fixes in #244 and fox-it/dissect.regf#18.

@Schamper Schamper requested review from Schamper, Miauwkeru and pyrco and removed request for Miauwkeru July 27, 2023 10:45
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #331 (244b8b0) into main (c39a58f) will increase coverage by 0.02%.
The diff coverage is 73.10%.

@@            Coverage Diff             @@
##             main     #331      +/-   ##
==========================================
+ Coverage   71.69%   71.72%   +0.02%     
==========================================
  Files         236      238       +2     
  Lines       18366    18682     +316     
==========================================
+ Hits        13168    13399     +231     
- Misses       5198     5283      +85     
Flag Coverage Δ
unittests 71.72% <73.10%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
dissect/target/target.py 75.75% <0.00%> (-0.39%) ⬇️
dissect/target/loaders/smb.py 71.01% <71.01%> (ø)
dissect/target/filesystems/smb.py 78.30% <78.30%> (ø)
dissect/target/loader.py 92.40% <100.00%> (+0.09%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Schamper Schamper self-assigned this Jul 28, 2023
@Schamper Schamper removed their request for review July 28, 2023 00:08
dissect/target/filesystems/smb.py Outdated Show resolved Hide resolved
dissect/target/filesystems/smb.py Outdated Show resolved Hide resolved
dissect/target/filesystems/smb.py Outdated Show resolved Hide resolved
dissect/target/filesystems/smb.py Outdated Show resolved Hide resolved
dissect/target/loaders/smb.py Outdated Show resolved Hide resolved
dissect/target/loaders/smb.py Show resolved Hide resolved
dissect/target/loaders/smb.py Show resolved Hide resolved
dissect/target/target.py Show resolved Hide resolved
@Schamper Schamper requested a review from Miauwkeru July 28, 2023 14:19
Miauwkeru
Miauwkeru previously approved these changes Jul 31, 2023
Copy link
Contributor

@Miauwkeru Miauwkeru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Schamper Schamper requested a review from Miauwkeru August 3, 2023 10:38
@Schamper Schamper merged commit b8e3d32 into fox-it:main Aug 17, 2023
10 checks passed
Poeloe pushed a commit that referenced this pull request Feb 29, 2024
Co-authored-by: Schamper <1254028+Schamper@users.noreply.github.com>
Zawadidone pushed a commit to Zawadidone/dissect.target that referenced this pull request Apr 5, 2024
Co-authored-by: Schamper <1254028+Schamper@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants