Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugins for volatile Linux artefacts #241

Merged
merged 30 commits into from
Sep 14, 2023

Conversation

Horofic
Copy link
Contributor

@Horofic Horofic commented Apr 25, 2023

(DIS-1443)

@Horofic Horofic requested review from Schamper and pyrco April 25, 2023 15:08
@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Merging #241 (aeb92ea) into main (ea2aa14) will increase coverage by 0.55%.
The diff coverage is 94.72%.

@@            Coverage Diff             @@
##             main     #241      +/-   ##
==========================================
+ Coverage   72.72%   73.27%   +0.55%     
==========================================
  Files         239      245       +6     
  Lines       19051    19543     +492     
==========================================
+ Hits        13855    14321     +466     
- Misses       5196     5222      +26     
Flag Coverage Δ
unittests 73.27% <94.72%> (+0.55%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
dissect/target/plugins/os/unix/linux/proc.py 93.56% <93.56%> (ø)
dissect/target/plugins/os/unix/linux/_os.py 92.59% <100.00%> (ø)
dissect/target/plugins/os/unix/linux/cmdline.py 100.00% <100.00%> (ø)
dissect/target/plugins/os/unix/linux/environ.py 100.00% <100.00%> (ø)
dissect/target/plugins/os/unix/linux/netstat.py 100.00% <100.00%> (ø)
dissect/target/plugins/os/unix/linux/processes.py 100.00% <100.00%> (ø)
dissect/target/plugins/os/unix/linux/sockets.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

dissect/target/plugins/os/unix/cmdline.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/unix/cmdline.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/unix/cmdline.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/unix/environ.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/unix/netstat.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/unix/proc.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/unix/proc.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/unix/proc.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/unix/proc.py Outdated Show resolved Hide resolved
tests/test_unix_proc.py Outdated Show resolved Hide resolved
@pyrco
Copy link
Contributor

pyrco commented May 4, 2023

These files should also be 1 layer lower under unix/linux/ as /proc and /sys are linux specific. This probably also has some repercussions on the record names which are now unix/proc/....

dissect/target/plugins/os/unix/proc.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/unix/proc.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/unix/proc.py Outdated Show resolved Hide resolved
@Horofic Horofic force-pushed the DIS-1443_add-volatile-linux-plugins branch 2 times, most recently from fb9781b to c895464 Compare June 8, 2023 07:09
@Horofic Horofic requested a review from pyrco June 8, 2023 07:19
@Horofic Horofic force-pushed the DIS-1443_add-volatile-linux-plugins branch from c895464 to aa2a933 Compare June 8, 2023 07:19
@Horofic Horofic force-pushed the DIS-1443_add-volatile-linux-plugins branch from aa2a933 to 643f526 Compare June 8, 2023 07:20
@Horofic Horofic self-assigned this Jun 8, 2023
dissect/target/plugins/os/unix/netstat.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/unix/netstat.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/unix/netstat.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/unix/linux/proc.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/unix/linux/proc.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/unix/linux/proc.py Outdated Show resolved Hide resolved
Horofic and others added 5 commits July 5, 2023 16:12
Co-authored-by: pyrco <105293448+pyrco@users.noreply.github.com>
Co-authored-by: pyrco <105293448+pyrco@users.noreply.github.com>
Co-authored-by: pyrco <105293448+pyrco@users.noreply.github.com>
…it/dissect.target into DIS-1443_add-volatile-linux-plugins
@Horofic Horofic requested a review from pyrco July 5, 2023 14:21
Copy link
Contributor

@pyrco pyrco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rebase on or merge in main to see if everything still works? There are quiet some changes.

pyrco
pyrco previously approved these changes Jul 7, 2023
dissect/target/plugins/os/unix/linux/proc.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/unix/linux/proc.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/unix/linux/proc.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/unix/linux/proc.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/unix/linux/proc.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/unix/netstat.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/unix/sockets.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/unix/sockets.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/unix/sockets.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/unix/sockets.py Outdated Show resolved Hide resolved
tests/data/proc/net/packet Outdated Show resolved Hide resolved
tests/test_unix_proc.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/unix/sockets.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/unix/netstat.py Outdated Show resolved Hide resolved
tests/test_unix_proc_sockets.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/unix/linux/cmdline.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/unix/linux/cmdline.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/unix/linux/cmdline.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/unix/linux/cmdline.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/unix/linux/proc.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/unix/linux/proc.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/unix/linux/proc.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/unix/linux/processes.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/unix/linux/processes.py Outdated Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/unix/linux/sockets.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/unix/linux/sockets.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/unix/linux/sockets.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/unix/linux/sockets.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/unix/linux/sockets.py Outdated Show resolved Hide resolved
@Schamper Schamper merged commit 0ed80a0 into main Sep 14, 2023
18 checks passed
@Schamper Schamper deleted the DIS-1443_add-volatile-linux-plugins branch September 14, 2023 14:29
Poeloe pushed a commit that referenced this pull request Feb 29, 2024
Co-authored-by: pyrco <105293448+pyrco@users.noreply.github.com>
Co-authored-by: Erik Schamper <1254028+Schamper@users.noreply.github.com>
Zawadidone pushed a commit to Zawadidone/dissect.target that referenced this pull request Apr 5, 2024
Co-authored-by: pyrco <105293448+pyrco@users.noreply.github.com>
Co-authored-by: Erik Schamper <1254028+Schamper@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants