Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logging of incompatible plugins #395

Merged
merged 8 commits into from
Sep 14, 2023
Merged

Conversation

Schamper
Copy link
Member

@Schamper Schamper commented Sep 13, 2023

Blocks #241.

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #395 (a53b4bd) into main (e5da4e4) will increase coverage by 0.23%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##             main     #395      +/-   ##
==========================================
+ Coverage   72.49%   72.72%   +0.23%     
==========================================
  Files         239      239              
  Lines       19052    19051       -1     
==========================================
+ Hits        13811    13855      +44     
+ Misses       5241     5196      -45     
Flag Coverage Δ
unittests 72.72% <85.71%> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
dissect/target/tools/query.py 52.00% <66.66%> (+16.50%) ⬆️
dissect/target/plugin.py 90.40% <100.00%> (-0.99%) ⬇️
dissect/target/target.py 78.51% <100.00%> (+0.38%) ⬆️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Schamper Schamper merged commit ea2aa14 into main Sep 14, 2023
18 checks passed
@Schamper Schamper deleted the fix-incompatible-plugin-log branch September 14, 2023 09:35
Poeloe pushed a commit that referenced this pull request Feb 29, 2024
Zawadidone pushed a commit to Zawadidone/dissect.target that referenced this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants