Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with cstruct v4 #717

Merged
merged 18 commits into from
Jun 5, 2024
Merged

Conversation

Miauwkeru
Copy link
Contributor

Closes #584

dissect/target/helpers/protobuf.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/unix/log/journal.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/windows/adpolicy.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/unix/log/utmp.py Outdated Show resolved Hide resolved
dissect/target/helpers/ssh.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/windows/regf/shimcache.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/windows/sam.py Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
pyrco
pyrco previously approved these changes Jun 4, 2024
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 98.64865% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.93%. Comparing base (4962256) to head (24fbb98).

Files Patch % Lines
dissect/target/plugins/os/windows/defender.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #717      +/-   ##
==========================================
- Coverage   74.96%   74.93%   -0.03%     
==========================================
  Files         292      292              
  Lines       24955    24930      -25     
==========================================
- Hits        18708    18682      -26     
- Misses       6247     6248       +1     
Flag Coverage Δ
unittests 74.93% <98.64%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Miauwkeru Miauwkeru merged commit ce6c4b8 into main Jun 5, 2024
16 of 18 checks passed
@Miauwkeru Miauwkeru deleted the DIS-2994_Compatibility-with-cstruct-v4 branch June 5, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Patch dissect.target with cstruct v.4
2 participants