Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more fields to imap_filter #449

Closed
wants to merge 7 commits into from
Closed

Conversation

angelnu
Copy link

@angelnu angelnu commented Jan 31, 2022

I added the missing rcpts and address as in the check commands. This helps me to filter based on the original recipe of the email which I expect to change less than the sender.

@angelnu
Copy link
Author

angelnu commented Jan 31, 2022

@foxcpp - I copied the code for rcpts and therefore it uses new-line separators. Maybe we prefer commas as for the aliases?

@foxcpp foxcpp self-requested a review February 1, 2022 18:46
@angelnu angelnu requested a review from foxcpp February 3, 2022 23:00
@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2022

Codecov Report

Merging #449 (7a06fa2) into master (dca3eb7) will decrease coverage by 0.02%.
The diff coverage is 15.78%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #449      +/-   ##
==========================================
- Coverage   54.15%   54.13%   -0.03%     
==========================================
  Files         123      123              
  Lines       10333    10343      +10     
==========================================
+ Hits         5596     5599       +3     
- Misses       4107     4115       +8     
+ Partials      630      629       -1     
Flag Coverage Δ
integration 34.95% <15.78%> (-0.03%) ⬇️
unit 55.20% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/imap_filter/command/command.go 1.96% <0.00%> (-0.19%) ⬇️
internal/imap_filter/group.go 5.88% <0.00%> (ø)
internal/storage/imapsql/delivery.go 33.76% <60.00%> (+0.87%) ⬆️
internal/target/remote/security.go 56.88% <0.00%> (+0.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dca3eb7...7a06fa2. Read the comment docs.

@foxcpp foxcpp self-assigned this Feb 19, 2022
@foxcpp
Copy link
Owner

foxcpp commented Feb 19, 2022

Manually merged into dev branch as d60ce83. Thanks a lot for your work!

@foxcpp foxcpp closed this Feb 19, 2022
@angelnu angelnu deleted the more-fields branch October 16, 2022 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants